NIFI-11269 Added snappy dependency

[johnAlJunior]

Summary

NIFI-11269

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 11
  • JDK 17

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[johnAlJunior]

Hi can someone look at this and verify its good?

[exceptionfactory]

Thanks for the contribution @johnAlJunior.

One minor note, the explicit version number for snappy-java should be removed because it is provided from the project root Maven configuration.

Otherwise, it looks like this change aligns with the inclusion of the snappy-java library in nifi-record-serialization-services for the AvroReader.

[exceptionfactory]

@johnAlJunior If you can remove the version number and rebase the pull request so that it does not contain merge commits, it should be ready to go.

[johnAlJunior]

Hi I removed the version, but I don't know how to rebase the pull request...

[johnAlJunior]

Done it.
Can you review?

[exceptionfactory]

Thanks for removing the version @johnAlJunior, the latest version looks good. I can cherry pick the necessary commits.

For future reference, merge commits should be avoided in pull requests, instead, changes from the main branch be rebased on to the branch, and then the pull request branch can be pushed, or force-pushed if necessary. An article from Atlassian has some useful background on merging vs. rebasing.

[johnAlJunior]

Thanks! Will do from now... Happy to contribute!