NIFI-11367 Database DATE value displayed incorrectly in record output… #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if timezone is GMT-X
turcsanyip
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Thanks @krisztina-zsihovszki for fixing it!
After moving to local time zone in NIFI-8768, this UTC conversion (from NIFI-8023) is not needed anymore.
+1 LGTM
@exceptionfactory Does it look good to you too? Any additional notes from your side?
exceptionfactory
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Thanks for the correction @krisztina-zsihovszki, I agree with @turcsanyip that this change looks good. The conversion of the implicitly local java.sql.Date to UTC is not necessary. +1
|
Thanks @exceptionfactory ! |
asfgit
pushed a commit
that referenced
this pull request
Apr 2, 2023
… if timezone is GMT-X This closes #7103. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
r-vandenbos
pushed a commit
to r-vandenbos/nifi
that referenced
this pull request
Apr 11, 2023
… if timezone is GMT-X This closes apache#7103. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… if timezone is GMT-X
Summary
NIFI-11367
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation