Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-11549: implemented AzureQueueStorage_v12 processors #7269

Closed
wants to merge 5 commits into from
Closed

NIFI-11549: implemented AzureQueueStorage_v12 processors #7269

wants to merge 5 commits into from

Conversation

emiliosetiadarma
Copy link
Contributor

Summary

NIFI-11549

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@nandorsoma nandorsoma self-requested a review May 22, 2023 08:41
@emiliosetiadarma emiliosetiadarma marked this pull request as ready for review May 22, 2023 17:00
exceptionfactory
exceptionfactory reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing these new Processors @emiliosetiadarma. I noticed a few issues, most of which are carry overs from the older versions that should be corrected in these new versions.

...c/test/java/org/apache/nifi/processors/azure/storage/queue/TestGetAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...c/test/java/org/apache/nifi/processors/azure/storage/queue/TestGetAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...c/test/java/org/apache/nifi/processors/azure/storage/queue/TestPutAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/PutAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/PutAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/GetAzureQueueStorage_v12.java Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/GetAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/GetAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/PutAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
...s/src/main/java/org/apache/nifi/processors/azure/storage/queue/PutAzureQueueStorage_v12.java Outdated Show resolved Hide resolved
exceptionfactory
exceptionfactory approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the feedback @emiliosetiadarma! The latest version looks good. I will also annotate the GetAzureQueueStorage and PutAzureQueueStorage Processors as deprecated with these new versions listed as alternatives. +1 merging

exceptionfactory pushed a commit that referenced this pull request Jun 5, 2023
@emiliosetiadarma @exceptionfactory
NIFI-11549 Added AzureQueueStorage_v12 Processors
a963434 
- Deprecated GetAzureQueueStorage and PutAzureQueueStorage

This closes #7269

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit b11373a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

@nandorsoma nandorsoma Awaiting requested review from nandorsoma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emiliosetiadarma @exceptionfactory