Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11587: update questdb from 6.5.5-jdk8 to 6.7-jdk8 #7291

Closed
wants to merge 1 commit into from

Conversation

r-sidd
Copy link
Contributor

@r-sidd r-sidd commented May 25, 2023

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory
Copy link
Contributor

@r-sidd Thank you for the contribution. Incremental changes do not necessarily require code changes, but sometimes libraries change behavior. Unfortunately it appears that this is one of those instances.

Please run a full local build of the project at minimum before submitting a pull request, as that surfaces some code changes required. For further background, please review Managing Project Dependencies for recommended steps related to upgrading dependencies.

I am closing this pull request for now given the automated build failures, but if you have a successful build and confirm the required changes, feel free to reopen or submit a new PR.

@r-sidd
Copy link
Contributor Author

r-sidd commented May 25, 2023

@r-sidd Thank you for the contribution. Incremental changes do not necessarily require code changes, but sometimes libraries change behavior. Unfortunately it appears that this is one of those instances.

Please run a full local build of the project at minimum before submitting a pull request, as that surfaces some code changes required. For further background, please review Managing Project Dependencies for recommended steps related to upgrading dependencies.

I am closing this pull request for now given the automated build failures, but if you have a successful build and confirm the required changes, feel free to reopen or submit a new PR.

Sorry about that, will do a local build and raise a PR, thanks :)

@r-sidd r-sidd deleted the NIFI-11587 branch May 31, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants