NIFI-11691: Support VARBINARY and LONGVARBINARY types in PutDatabaseRecord #7380
Conversation
There was a problem hiding this comment.
Thanks for addressing this issue @mattyb149, the general approach looks good, but I noted a couple questions about the alternative type handling.
| try { | ||
| ps.setBytes(index, byteArray); | ||
| } catch (SQLException e) { | ||
| throw new IOException("Unable to parse binary data " + value, e.getCause()); |
There was a problem hiding this comment.
Given the potential size of these objects, recommend replacing value the array length to avoid extremely large log messages.
| try { | ||
| ps.setBytes(index, value.toString().getBytes(StandardCharsets.UTF_8)); | ||
| } catch (SQLException e) { | ||
| throw new IOException("Unable to parse binary data " + value, e.getCause()); |
There was a problem hiding this comment.
As noted above, recommend replacing value with the length of the bytes.
| } | ||
| } else { | ||
| try { | ||
| ps.setBytes(index, value.toString().getBytes(StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
It might be worth adding a comment on this line, since value.toString() may not provide an expected representation of the underlying object type. Perhaps there should be some additional type checking in this conditional to determine if value is an array type or collection type, otherwise it seems like this could produce unexpected results.
There was a problem hiding this comment.
This is just in case the data came in as a String
Summary
NIFI-11691 This PR adds support for the java.sql.Types VARBINARY and LONGVARBINARY in PutDatabaseRecord. It converts the record field value to
byte[]and then callssetBytes()when setting the parameter value in the PreparedStatementTracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation