NIFI-11898: Handle auto-commit and commit based on driver capabilities in PutDatabaseRecord #7561
Conversation
There was a problem hiding this comment.
Thanks for addressing this issue @mattyb149! The change looks straightforward, and makes the implementation more resilient for JDBC Drivers that do not support auto commit handling. I noted a couple questions.
|
|
||
| putToDatabase(context, session, flowFile, connection); | ||
| connection.commit(); | ||
| // Only commit the connection if auto-commit is false | ||
| if (!connection.getAutoCommit()) { |
There was a problem hiding this comment.
Should this be changed to check originalAutoCommit instead of calling connection.getAutoCommit() again?
| if (!connection.getAutoCommit()) { | |
| if (!originalAutoCommit) { |
|
|
||
| @Override | ||
| public String getIdentifier() { | ||
| return "dbcp"; |
There was a problem hiding this comment.
Recommend setting a static final variable named DBCP_SERVICE_ID and reusing across this test class.
| @Override | ||
| public Connection getConnection() throws ProcessException { | ||
| try { | ||
| Class.forName("org.apache.derby.jdbc.EmbeddedDriver"); |
There was a problem hiding this comment.
Is this Class.forName() call required?
mattyb149
force-pushed
the
NIFI-11898_main
branch
from
5b18f80
to
990be8d
Compare
There was a problem hiding this comment.
Thanks for making the adjustments @mattyb149. The test changes cover the various code paths, and runtime behavior works as expected. +1 merging
Summary
NIFI-11898 This is the
mainversion of PR #7560 , please see the other PR for details.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation