NIFI-11896 Correct QuestDB Status Repository Shutdown handling #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated QuestDB Status Repository shutdown method to cancel scheduled tasks before immediate shutdown of Scheduled Executor Service - Updated QuestDB Scheduled Tasks to include initial delay to avoid unnecessary execution when starting - Updated QuestDB test class to minimize logging for QuestDB 7 - Improved logging and exception messages
|
Two full clean builds with all the trimmings worked perfectly/. And no dumpstream. Nice! |
pvillard31
approved these changes
Aug 3, 2023
asfgit
pushed a commit
that referenced
this pull request
Aug 3, 2023
- Updated QuestDB Status Repository shutdown method to cancel scheduled tasks before immediate shutdown of Scheduled Executor Service - Updated QuestDB Scheduled Tasks to include initial delay to avoid unnecessary execution when starting - Updated QuestDB test class to minimize logging for QuestDB 7 - Improved logging and exception messages Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes #7564.
exceptionfactory
added a commit
to exceptionfactory/nifi
that referenced
this pull request
Aug 14, 2023
- Updated QuestDB Status Repository shutdown method to cancel scheduled tasks before immediate shutdown of Scheduled Executor Service - Updated QuestDB Scheduled Tasks to include initial delay to avoid unnecessary execution when starting - Updated QuestDB test class to minimize logging for QuestDB 7 - Improved logging and exception messages Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com> This closes apache#7564.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11896 Corrects QuestDB Status Repository shutdown handling at runtime and during unit tests.
Changes include updating the repository start and shutdown methods to track scheduled future tasks and attempt cancellation before shutting down the executor service. This approach provides a stronger guarantee of stopping scheduled tasks than shutting down the executor service itself.
Additional changes include setting the initial delay for scheduled tasks from 0 to the configured interval, avoiding initial execution when starting the repository. This approach avoids unnecessary task execution in unit tests.
Test changes include setting the
outSystem property pointing to the QuestDB logging configuration, avoiding unnecessary debug logs during unit testing, which can corrupt the console output stream, described in NIFI-11897.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation