Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-11908 Update GitHub Build HTTP Settings #7573

Closed
wants to merge 1 commit into from

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-11908 Updates the GitHub workflow Maven HTTP settings to use the native client settings instead of the Maven Wagon properties.

With the introduction of Maven Wrapper using Maven 3.9, the native HTTP transport is now the default, as described in the Maven 3.9 Release Notes.

These changes replace the Maven Wagon properties with a subset of the analogous properties for the Maven Artifact Resolver.

Additional changes include removing the disableXmlReport argument, which is deprecated in recent versions of the Maven Surefire Plugin.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Replaced Maven Wagon properties to Maven Native HTTP properties as required for Maven 3.9
- Removed the deprecated disableXmlReport argument
@mattyb149 mattyb149 closed this in 3a6f86f Aug 3, 2023
@mattyb149
Copy link
Contributor

+1 LGTM, thanks for the improvement! Merging to support/nifi-1.x and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants