NIFI-11518 Upgrade Jetty from 9.4.51 to 10.0.15 #7622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated Jetty WebSocket components using Jetty 10 components - Upgraded Solr components from 8.11.2 to 9.2.1 to align with Jetty 10 dependencies
|
+1 LGTM, thanks for the upgrade, this will certainly improve the situation for NiFi 2.0. Merging to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-11518 Upgrades Jetty dependencies from 9.4.51 to 10.0.15.
Jetty 10 represents a major version change that requires Java 11 as the minimum version, but retains compatibility with the
javax.servletinterfaces. This provides an incremental upgrade approach without more substantial changes that would be required to adopt Jetty 11.Most of the package and module names remain the same between Jetty 9.4 and 10, with the notable exception of the WebSocket libraries, as highlighted in the Jetty Migration Guide from 9.4 to 10. These changes are reflected in the updates to the Jetty WebSocket Processors and Services.
Additional changes include upgrading Solr dependencies from 8.11.2 to 9.2.1 in order to align with Jetty 10 dependencies. The Jetty
ELContextCleanerclass is deprecated and removed from the default web application configuration.The Hadoop Client libraries also have a dependency on Jetty 9.4 WebSocket libraries for Yarn shell access. Yarn shell access is not necessary for NiFi component operation, but the referencing Hadoop class imports the Jetty client class. For this reason, several Maven configurations exclude Jetty 9.4 and include Jetty 10 WebSocket client to avoid runtime exceptions.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation