NIFI-12260: Remove templates from frontend

[sardell]

Summary

NIFI-12260

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[rfellows]

There are build failures:

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  08:24 min
[INFO] Finished at: 2023-10-24T00:29:02Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal net.alchim31.maven:yuicompressor-maven-plugin:1.5.1:compress (minify) on project nifi-web-ui: wrap: /home/runner/work/nifi/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/target/tmp/js/nf/canvas/header/components/nf-ng-template-component.js (No such file or directory) -> [Help 1]

That file seems to be referenced in 2 places...
looks like it is referenced in 2 places:

• line 561 in nifi-web-ui/pom.xml
• and line 91 in nifi-web-ui/src/main/resources/filters/canvas.properties

[rfellows]

On the canvas context menu, there are 2 template-related options that need to be removed.

Clicking them now produces an error on the console:

nf-context-menu.js?2.0.0-SNAPSHOT:794 Uncaught TypeError: nfActions[action] is not a function
    at executeAction (nf-context-menu.js?2.0.0-SNAPSHOT:794:26)
    at HTMLDivElement.<anonymous> (nf-context-menu.js?2.0.0-SNAPSHOT:945:21)
    at HTMLDivElement.dispatch (jquery.min.js:2:43184)
    at $event.dispatch (jquery.event.drag-2.3.0.js:387:30)
    at y.handle (jquery.min.js:2:41168)

There are quite a few remaining references to templates in the app.

• templates.jsp
• templates.properties
• templates-min.properties
• instantiate-template-dialog.jsp
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-context-menu.js#L121-L137
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-context-menu.js#L878-L879
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/web.xml#L69-L77
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/users/nf-users-table.js#L642-L643
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/users/nf-users-table.js#L696-L697
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L34
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L61
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L98
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L331-L337
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L452
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L666-L680
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L846-L855
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L914
• https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml#L938

There might be others, but these are the ones that I found.

[sardell]

@rfellows Thanks for taking a look. I see all these leftover references now and will update shortly.

[rfellows]

Mostly there. I think you got a bit overzealous with your removing of template stuff. In particular the stuff about policy templates. those aren't related.

There are a handful (10 i think) css styles in main.css that we could probably remove as well. #new-template-description { position: absolute; top: 81px; bottom: 0px; height: inherit; min-height: 32px; }
as well as others named like xxx-template-xxx

[elcsiga]

+1 once the policy-selected-templates are clarified. Looks good, I couldn't find any remaining template related code

[elcsiga]

(just to make sure: there is an icon-template-import used here:

I can still import a complete flow here, so I suppose this is ok as is.)

[rfellows]

(just to make sure: there is an icon-template-import used here:

I can still import a complete flow here, so I suppose this is ok as is.)

I think this is OK. It is just the icon. You can either select a file to upload or you enter a name to give an empty process group. You can't pick a template here.

[rfellows]

Latest changes look good. Thanks @sardell!