Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2494 Remove extraneous text that shows on banner line #793

Closed
wants to merge 2 commits into from

Conversation

jskora
Copy link
Contributor

@jskora jskora commented Aug 5, 2016

Removed the text from the JSP source.

@mcgilman
Copy link
Contributor

mcgilman commented Aug 5, 2016

Reviewing...

@mcgilman
Copy link
Contributor

mcgilman commented Aug 5, 2016

@jskora Thanks for the PR. I just tried it out and was able to replicate the issue. However, with your proposed change, the heading text on the Controller Settings dialog is missing. This is accessed through the global menu and selecting 'Controller Settings'.

I think the underlying issue is that the default visibility is not being set on the settings dialog [1]. By adding class="hidden" to the settings div, I believe the issue is resolved. Would you mind trying that locally and if you agree update the PR?

Thanks again!

[1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/settings-content.jsp#L18

@jskora
Copy link
Contributor Author

jskora commented Aug 5, 2016

Working on it now.

* Reverse text change and change div visibility instead, to prevent impact to Controller Settings page.
@jskora
Copy link
Contributor Author

jskora commented Aug 5, 2016

@mcgilman, I restored the text and added the class to the div tag. My canvas is still fixed and the title is back on the Controller Settings page.

Thanks for catching that.

@asfgit asfgit closed this in 903b1fe Aug 5, 2016
@mcgilman
Copy link
Contributor

mcgilman commented Aug 5, 2016

Thanks @jskora. I've merged this to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants