Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12323 Configure StreamReadConstraints on the ObjectMapper used b… #7985

Closed
wants to merge 1 commit into from

Conversation

bbende
Copy link
Contributor

@bbende bbende commented Nov 6, 2023

…y StandardDataFlow

Summary

NIFI-12323

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @bbende. Although it is somewhat of an edge case to have large string values for JSON elements in the flow configuration, this makes sense for scenarios with scripted components or other reference items. Given that the application manages the content of the JSON directly, this change seems reasonable and restores the behavior prior to Jackson 2.14. +1 merging

exceptionfactory pushed a commit that referenced this pull request Nov 7, 2023
- Configured StreamReadConstraints on the ObjectMapper used by StandardDataFlow

This closes #7985

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 940c927)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants