Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-12364 Upgrade snowflake-ingest-sdk to 2.0.4 #8022

Closed
wants to merge 2 commits into from
Closed

NIFI-12364 Upgrade snowflake-ingest-sdk to 2.0.4 #8022

wants to merge 2 commits into from

Conversation

mr1716
Copy link
Contributor

@mr1716 mr1716 commented Nov 13, 2023

Summary

NIFI-12364

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory
Copy link
Contributor

@turcsanyip, based on past compatibility issues, I also reviewed the release notes for the Snowflake JDBC Driver version 3.14.3, which notes a fix in connection for Snowflake Ingest SDK 2.0.3. This minor version update to SDK 2.0.4 probably warrants some additional review.

@turcsanyip
Copy link
Contributor

turcsanyip commented Nov 14, 2023 •
edited

Thanks for the heads-up @exceptionfactory!
Yes, Snowflake JDBC Driver 3.14.3 fixes the compatibility issue with Snowflake Ingest SDK. I tested it with different flows and did not get the previous or other errors (only the known NIFI-10883). So I suggest upgrading the snowflake-jdbc dependency to 3.14.3 also.

@mr1716
Copy link
Contributor Author

mr1716 commented Nov 14, 2023

@exceptionfactory @turcsanyip should I also add a change to snowflake-jdbc as noted above for this PR?

@exceptionfactory
Copy link
Contributor

@exceptionfactory @turcsanyip should I also add a change to snowflake-jdbc as noted above for this PR?

@mr1716 Yes, it would be helpful to make that change in this PR so they are upgraded together.

@mr1716
Copy link
Contributor Author

mr1716 commented Nov 14, 2023

@exceptionfactory thanks. The change has been made and is awaiting approval. Much appreciated!

turcsanyip
turcsanyip approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mr1716!

+1 LGTM
Merging to main and 1.x support branches.

@asfgit asfgit closed this in e0527a8 Nov 14, 2023
asfgit pushed a commit that referenced this pull request Nov 14, 2023
@mr1716 @turcsanyip
NIFI-12364 Upgrade snowflake-ingest-sdk to 2.0.4 and snowflake-jdbc t…
e0c12be 
…o 3.14.3

This closes #8022.

Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
(cherry picked from commit e0527a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turcsanyip turcsanyip turcsanyip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mr1716 @exceptionfactory @turcsanyip