NIFI-12485: Lineage Graph #8173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lineage.
- Adding context menu to lineage graph. - Refactoring canvas context menu to promote reuse.
- Lineage timeline slider.
mcgilman
added
the
new ui
|
Will review. |
rfellows
requested changes
Dec 20, 2023
There was a problem hiding this comment.
I noticed some rendering issues in the lineage graph sometimes when expanding nodes (in particular FORKs):
It doesn't happen on all events, but does happen consistently with the certain events. One note, when setting a breakpoint in the lineage.component.ts line 900, and stepping through the expand action, the issue does NOT present itself. So it is probably something with in the timing 😞
Also, a few things inline...
...i/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-listing.component.ts
Show resolved
Hide resolved
...eb/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/state/lineage/lineage.effects.ts
Outdated
Show resolved
Hide resolved
...eb/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/state/lineage/lineage.effects.ts
Outdated
Show resolved
Hide resolved
...eb/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/state/lineage/lineage.effects.ts
Outdated
Show resolved
Hide resolved
...eb/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/state/lineage/lineage.effects.ts
Outdated
Show resolved
Hide resolved
...nance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.ts
Outdated
Show resolved
Hide resolved
...s/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts
Outdated
Show resolved
Hide resolved
...s/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts
Outdated
Show resolved
Hide resolved
...s/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts
Outdated
Show resolved
Hide resolved
...nce/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html
Outdated
Show resolved
Hide resolved
- Addressing review feedback.
|
Thanks for the review @rfellows! I've addressed the items you've mentioned and fixed the rendering issues as well. Please have a look at the latest commit. |
rfellows
requested changes
Dec 21, 2023
...nce/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html
Outdated
Show resolved
Hide resolved
...s/provenance/ui/provenance-event-listing/provenance-event-table/lineage/lineage.component.ts
Show resolved
Hide resolved
- Addressing review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-12485: