Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-12587 - improve error message in ValidateCSV #8224

Closed
wants to merge 6 commits into from
Closed

NIFI-12587 - improve error message in ValidateCSV #8224

wants to merge 6 commits into from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-12587 - improve error message in ValidateCSV

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

EndzeitBegins
EndzeitBegins approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@EndzeitBegins EndzeitBegins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pvillard31 and others added 4 commits January 9, 2024 22:43
@pvillard31 @dan-s1
Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors…
5af952a 
…/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java

Co-authored-by: dan-s1 <dstieg1@gmail.com>
@pvillard31 @dan-s1
Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors…
d24aa2f 
…/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java

Co-authored-by: dan-s1 <dstieg1@gmail.com>
@pvillard31 @dan-s1
Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors…
642f3d1 
…/src/test/java/org/apache/nifi/processors/standard/TestValidateCsv.java

Co-authored-by: dan-s1 <dstieg1@gmail.com>
@pvillard31 @dan-s1
Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors…
cfb8b10 
…/src/test/java/org/apache/nifi/processors/standard/TestValidateCsv.java

Co-authored-by: dan-s1 <dstieg1@gmail.com>
@dan-s1
Copy link
Contributor

dan-s1 commented Jan 9, 2024

LGTM+1

ChrisSamo632
ChrisSamo632 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ChrisSamo632 ChrisSamo632 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Will merge tomorrow if noone beats me to it

@mattyb149
Copy link
Contributor

+1 LGTM, thanks for the improvement! Merging to support/nifi-1.x and main

@mattyb149 mattyb149 closed this in 415505e Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-s1 dan-s1 dan-s1 left review comments

@ChrisSamo632 ChrisSamo632 ChrisSamo632 approved these changes

@EndzeitBegins EndzeitBegins EndzeitBegins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@pvillard31 @dan-s1 @mattyb149 @ChrisSamo632 @EndzeitBegins