NIFI-2531: Fixed JdbcCommon handling of BigInteger objects for Avro

[mattyb149]

No description provided.

[bbende]

Reviewing...

[bbende]

Tested this out with MySQL, created a table like the following:

mysql> CREATE TABLE BIGINT_TEST (id bigint(20) unsigned, name varchar(255));
Query OK, 0 rows affected (0.02 sec)

mysql> insert into BIGINT_TEST (id, name) values (22222222222222222222, "test");
Query OK, 1 row affected, 1 warning (0.00 sec)

mysql> select * from BIGINT_TEST;
+----------------------+------+
| id                   | name |
+----------------------+------+
| 18446744073709551615 | test |
+----------------------+------+
1 row in set (0.00 sec)

Verified I got the error before your patch, then applied it and got a different error:

java.lang.ArithmeticException: BigInteger out of long range
    at java.math.BigInteger.longValueExact(BigInteger.java:4383) ~[na:1.8.0_74]
    at org.apache.nifi.processors.standard.util.JdbcCommon.convertToAvroStream(JdbcCommon.java:125) ~[na:na]

I understand there isn't much we can do here because the value is too big for a long, but would we better off representing BIGINT as a string in the schema and output so that we never run into an error?

I realize we lose the typing then, but not sure if having some of the data typed and some with errors is better or worse.

[mattyb149]

Good point, let me see if I can use the column width (for BIGINT types) to determine whether to expect a long or string in the value.

[bbende]

Latest update looks good, nice work! Will merge to master