Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… #8240

Closed
wants to merge 2 commits into from
Closed

NIFI-12590 Add options to add a prefix on Kubernetes resources for Cl… #8240

wants to merge 2 commits into from

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Jan 12, 2024 •
edited

…uster Leader Election and State Management

Summary

NIFI-12590

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

exceptionfactory
exceptionfactory requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this addition @juldrixx. I provided some recommendations on naming and implementation details.

...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...-framework-bundle/nifi-framework/nifi-framework-nar-utils/src/test/resources/nifi.properties Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/leader/election/KubernetesLeaderElectionManager.java Outdated Show resolved Hide resolved
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java Outdated Show resolved Hide resolved
@juldrixx juldrixx force-pushed the NIFI-12590 branch 6 times, most recently from b890518 to b76091f Compare January 12, 2024 17:45
@juldrixx
Copy link
Contributor Author

Thanks for proposing this addition @juldrixx. I provided some recommendations on naming and implementation details.

Thanks for the review, I should have made the requested changes.

exceptionfactory
exceptionfactory requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @juldrixx.

The latest build shows two Checkstyle warnings:

Warning:  src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:[123,62] (whitespace) OperatorWrap: '?' should be on a new line.
Warning:  src/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java:[125,79] (whitespace) OperatorWrap: '?' should be on a new line.

@juldrixx juldrixx force-pushed the NIFI-12590 branch 2 times, most recently from 74c68df to 2c25f70 Compare January 16, 2024 14:55
exceptionfactory
exceptionfactory requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @juldrixx. This looks close to completion, but I noted a few more recommendations to wrap this up.

...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
...rc/main/java/org/apache/nifi/kubernetes/state/provider/KubernetesConfigMapStateProvider.java Outdated Show resolved Hide resolved
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/pom.xml Outdated Show resolved Hide resolved
...-framework/nifi-framework-kubernetes-bundle/nifi-framework-kubernetes-state-provider/pom.xml Show resolved Hide resolved
exceptionfactory
exceptionfactory approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the feedback @juldrixx, and thanks for the review @mh013370, the latest version looks good. +1 merging

@juldrixx juldrixx deleted the NIFI-12590 branch January 25, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exceptionfactory exceptionfactory exceptionfactory approved these changes

@mh013370 mh013370 mh013370 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@juldrixx @exceptionfactory @mh013370