Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12640 Move servlet-api and jetty-schemas to nifi-jetty-bundle #8272

Merged
merged 1 commit into from Jan 19, 2024

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-12640 Moves the servlet-api and jetty-schemas JAR libraries from the root lib directory to the nifi-jetty-bundle NAR.

NIFI-3694 Moved these libraries to the root lib directory due to Logback ServletContextInitializer issues with Jetty 9.

Jetty 12 has different behavior that avoids startup failures related to ServletContainerInitializer implementations, instead logging an informational message. NiFi already disables the Logback ServletContainerInitializer using an environment variable, so it is not required for any logging operations.

Moving the servlet-api and jetty-schemas JAR libraries to nifi-jetty-bundle maintains their position at the effective root of the NAR Class Loading hierarchy while keeping them packaged in the Jetty NAR.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Set Jetty AnnotationConfiguration log level to WARN suppressing informational messages related to Logback ServletContainerInitializer
Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will merge, thanks!

@bbende bbende merged commit e66da89 into apache:main Jan 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants