Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12643 Added support for FileResourceService in PutGCSObject #8281

Closed
wants to merge 4 commits into from

Conversation

balazsgerner
Copy link
Contributor

Summary

Added support to upload content directly from local file's inputstream (by-passing the content repository) inside the PutGCSObject processor. The default behaviour is upload from flowfile content to be backward compatible. This can be overridden if the RESOURCE_TRANSFER_SOURCE property value is set to FILE_RESOURCE_SERVICE, and a FileResourceService controller service is registered.

NIFI-12643

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@balazsgerner balazsgerner marked this pull request as ready for review January 23, 2024 12:52
@turcsanyip turcsanyip self-requested a review January 25, 2024 13:19
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balazsgerner for your first contribution!
Tested the new functionality and it works as expected, the code also looks good.
Added one minor comment regarding the position of the new properties on the UI.

balazsgerner and others added 2 commits January 25, 2024 16:28
Co-authored-by: Peter Turcsanyi <35004384+turcsanyip@users.noreply.github.com>
Co-authored-by: Peter Turcsanyi <35004384+turcsanyip@users.noreply.github.com>
Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balazsgerner!

+1 LGTM
Merging...

@asfgit asfgit closed this in bce14f5 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants