Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12680 Fix JAR for DefaultedDynamicClassPathModificationIT on Support Branch #8307

Closed

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-12680 Corrects the DefaultedDynamicClassPathModificationIT system test on the support branch following the same strategy as implemented on the current main branch. The test fails due to a hard-coded default property value referencing commons-lang3 3.13.0. The changes check the lib/bootstrap directory for the current available version.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Adjusted test flow to find available version of commons-lang3 instead of depending on a specific version from the default property value
@exceptionfactory
Copy link
Contributor Author

Based on GitHub Actions and local builds, there appears to be an unrelated problem with the ProvenanceRepositoryIT on Java 17.

Copy link
Contributor Author

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-merging this as a functional backport of the current method on the main branch. The issue related to ProvenanceRepositoryIT on Java 17 for the support branch can be addressed in a separate Jira issue.

exceptionfactory added a commit that referenced this pull request Feb 9, 2024
- Adjusted test flow to find available version of commons-lang3 instead of depending on a specific version from the default property value

This closes #8307

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant