New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String Escape Utils to Nifi Expression Language (redo) #833
Conversation
Made use of org.apache.commons.lang3.StringEscapeUtils to do that actual processing
This a redo for PR #777 |
Reviewing... |
I'm seeing CheckStyle errors: [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-expression-language --- Can you format this file? You can check to see if there are errors by going to the nifi-commons/nifi-expression-language module and running "mvn clean install -Pcontrib-check". |
…d license text block
Ok, fixed those errors and it now passes the contrib-check. |
@devin-fisher awesome how responsive you have been on this! Makes review/commit process much easier! Thank you |
+1 Great job! I built, ran, and tested the functions with escaped/unescaped inputs and empty strings, everything works well. Thanks again for the contribution! Will merge to master. |
jira:NIFI-2460
Added functions to escape and unescape common transport formats that are supported by common-lang's StringEscapeUtils.
Since I added ten functions, I created a new section in the Documentation. I also moved URL encode and decode there too.
Don't add a lot of unit tests since I'm directly piping it through to StringEscapeUtils and they have extensive testing there. The test are most to verify that it is going to the right function.