NIFI-12672 Added Azure specific versions of FileResourceService #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balazsgerner
force-pushed
the
NIFI-12672
branch
from
afe8a0a
to
9402a96
Compare
balazsgerner
changed the title
mark-bathori
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thanks @balazsgerner for implementing these new features. I've tested both ControllerServices and they work as expected. I've left a couple of comments please see them below.
...rc/main/java/org/apache/nifi/services/azure/storage/AzureBlobStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
turcsanyip
requested changes
Feb 23, 2024
...rc/main/java/org/apache/nifi/services/azure/storage/AzureBlobStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Show resolved
Hide resolved
...rc/main/java/org/apache/nifi/services/azure/storage/AzureBlobStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/nifi/services/azure/storage/AzureDataLakeStorageFileResourceService.java
Outdated
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Outdated
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Outdated
Show resolved
Hide resolved
...ocessors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
Outdated
Show resolved
Hide resolved
turcsanyip
approved these changes
Feb 26, 2024
mark-bathori
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Thanks @balazsgerner for working on this feature.
LGTM +1
Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12672
Implemented the Azure Blob Storage and Azure Data Lake Storage (ADLS) specific versions of
FileResourceServiceto be able to fetch data directly from these services, by-passing the content repository.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation