Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12671 Added AwsFileResourceService #8368

Closed
wants to merge 4 commits into from

Conversation

balazsgerner
Copy link
Contributor

Summary

NIFI-12671

Implemented the AWS S3 specific version of FileResourceService to be able to fetch data directly from this service, by-passing the content repository.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@mark-bathori mark-bathori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balazsgerner for implementing this new feature. I've tested the ControllerService and it works as expected, I was able to move my data from S3 to Azure. I've left a couple of comments please see them below.

@balazsgerner
Copy link
Contributor Author

Thanks @balazsgerner for implementing this new feature. I've tested the ControllerService and it works as expected, I was able to move my data from S3 to Azure. I've left a couple of comments please see them below.

Thanks for the review @mark-bathori, I pushed a commit with the review item fixes.

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balazsgerner Thanks for adding this new file resource service! I tested it with files of different sizes and it works properly. Please find some improvement comments below!

Copy link
Contributor

@mark-bathori mark-bathori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balazsgerner for fixing the review comments.
LGTM +1

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @balazsgerner!
+1 LGTM
Merging to main.

@asfgit asfgit closed this in 40d9750 Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants