-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-12671 Added AwsFileResourceService #8368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balazsgerner for implementing this new feature. I've tested the ControllerService
and it works as expected, I was able to move my data from S3 to Azure. I've left a couple of comments please see them below.
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
...i-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/AwsFileResourceService.java
Outdated
Show resolved
Hide resolved
...i-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/AwsFileResourceService.java
Outdated
Show resolved
Hide resolved
...i-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/AwsFileResourceService.java
Outdated
Show resolved
Hide resolved
...s-processors/src/test/java/org/apache/nifi/processors/aws/s3/AwsFileResourceServiceTest.java
Outdated
Show resolved
Hide resolved
Thanks for the review @mark-bathori, I pushed a commit with the review item fixes. |
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balazsgerner Thanks for adding this new file resource service! I tested it with files of different sizes and it works properly. Please find some improvement comments below!
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
...fi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/S3FileResourceService.java
Outdated
Show resolved
Hide resolved
...-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java
Outdated
Show resolved
Hide resolved
...i-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
Outdated
Show resolved
Hide resolved
...s-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestListS3.java
Outdated
Show resolved
Hide resolved
...ndle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/sqs/AbstractSQSIT.java
Outdated
Show resolved
Hide resolved
...fi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/S3FileResourceService.java
Outdated
Show resolved
Hide resolved
...fi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/S3FileResourceService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balazsgerner for fixing the review comments.
LGTM +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @balazsgerner!
+1 LGTM
Merging to main.
Summary
NIFI-12671
Implemented the AWS S3 specific version of FileResourceService to be able to fetch data directly from this service, by-passing the content repository.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation