Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12764 Removed Commons Codec and Lang3 from security-utils #8380

Merged
merged 1 commit into from Feb 9, 2024

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-12764 Removes commons-codec and commons-lang3 dependencies from nifi-security-utils to reduce the transitive dependencies inherited in other referencing modules.

Changes include replacing Commons Codec Hex with Java HexFormat and replacing StringUtils references with simple checks.

Commons Codec is a runtime dependency of OpenSAML, so it is now declared explicitly in nifi-web-security, and Commons Lang3 is a runtime dependency of the nifi-system-test-suite for dynamic class loading tests.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@markap14 markap14 merged commit 2ea4838 into apache:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants