NIFI-12773: Added join and anchored RecordPath function #8391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSamo632
requested changes
Feb 16, 2024
There was a problem hiding this comment.
Thanks for the useful updates @markap14 , just a couple of minor suggestions from me
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Anchored.java
Outdated
Show resolved
Hide resolved
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Anchored.java
Outdated
Show resolved
Hide resolved
...ons/nifi-record-path/src/main/java/org/apache/nifi/record/path/paths/RecordPathCompiler.java
Outdated
Show resolved
Hide resolved
…ed pom.xml to ensure that nifi-property-utils is now explicitly declared as a dependency
markap14
force-pushed
the
recordpath-improvements
branch
from
96b2acc
to
99c37ef
Compare
|
@ChrisSamo632 thanks for reviewing. Pushed a new commit that addresses your comments above. |
ChrisSamo632
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation