[NIFI-12754] - Flow Configuration History #8399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfellows
added
the
new ui
mcgilman
reviewed
Feb 13, 2024
...i/src/app/pages/flow-configuration-history/feature/flow-configuration-history.component.html
Show resolved
Hide resolved
...rc/app/pages/flow-configuration-history/feature/flow-configuration-history-routing.module.ts
Outdated
Show resolved
Hide resolved
...tory/ui/flow-configuration-history-listing/flow-configuration-history-listing.component.html
Show resolved
Hide resolved
...story/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts
Outdated
Show resolved
Hide resolved
...story-listing/flow-configuration-history-table/flow-configuration-history-table.component.ts
Outdated
Show resolved
Hide resolved
mcgilman
reviewed
Feb 14, 2024
...istory/ui/flow-configuration-history-listing/flow-configuration-history-listing.component.ts
Outdated
Show resolved
Hide resolved
| styleUrls: ['./flow-configuration-history-table.component.scss'] | ||
| }) | ||
| export class FlowConfigurationHistoryTable { | ||
| @Input() selectedHistoryActionId: number | null = null; |
There was a problem hiding this comment.
Does this need to be an @Input and saved in the state. We have a few other cases of table selection scenarios where we are not deep linking and the component just internally manages the selected row.
There was a problem hiding this comment.
It doesn't "need" to be. But it was a simple enough change to migrate from using the selection from the route to this. And it sets us up to change back to use the route for selection in the future if we choose.
...tory/ui/flow-configuration-history-listing/flow-configuration-history-listing.component.scss
Outdated
Show resolved
Hide resolved
* support selection * support pagination * support sorting * added time controls, also updated provenance to use them too * allow for clearing of filters * use date range filter * more details dialog for flow config history * support purge history
…een header and page content
rfellows
force-pushed
the
NIFI-12754-flowConfigHistory
branch
from
e68583a
to
86e10dd
Compare
…one to purge confirmation message * reset pagination state on filter, clear filter, and purge * only resubmit query when filter by changes IF there is a filter term specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-12754