[NIFI-12761] refresh RPG #8401
Merged
[NIFI-12761] refresh RPG #8401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottyaslan
added
the
new ui
|
Will review... |
mcgilman
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! Looking good, but I did note a few issues below.
...eb-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
Show resolved
Hide resolved
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
scottyaslan
force-pushed
the
NIFI-12761
branch
2 times, most recently
from
852a92f
to
2de3c91
Compare
mcgilman
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! Looks great. Just a couple minor things below.
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
scottyaslan
force-pushed
the
NIFI-12761
branch
from
91f35a4
to
53c1da1
Compare
mcgilman
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-12761