NIFI-12813 Correct Username handling in HTTP Request Log #8423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-12813 Corrects username handling in the application HTTP request log written to
nifi-request.log
in the default Logback configuration.Upgrading to Jetty 12 in NiFi 2.0.0-M2 required changing the filter responsible for setting the authenticated user required for the Jetty
CustomRequestLog
. The initial change referenced the wrongAuthenticationState
interface, resulting in a failure to retrieve the authenticated user attribute during the logging. This issue does not impact any authentication or authorization behavior and is limited to username logging, which can also be tracked using other loggers innifi-user.log
.Correcting the
AuthenticationState
interface reference resolves the problem, and can be validated by authenticating to NiFi and confirming the presence of the username in thenifi-request.log
. Additional changes include a new unit test to verify the presence of the expected request attribute name and value.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation