Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12850 - Prevent indexing of overly large filename attribute #8457

Closed
wants to merge 1 commit into from

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-12850 - Failure to index Provenance Events with large filename attribute

Easy way to test: GFF -> funnel and have a dynamic property in GFF that sets 'filename' with an excessively large value (for example 60k characters).

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@mattyb149
Copy link
Contributor

Does this have any ramifications for existing indexes?

@pvillard31
Copy link
Contributor Author

@mattyb149 - It does not have any impact on existing indexes. It is not possible to index a field with a value larger than this limit. As of now, the indexation of the document would fail and no provenance event would be stored in case the filename attribute is larger than the lucene limit for indexes.

@mattyb149
Copy link
Contributor

+1 LGTM, merging to support/1.x and main. Thanks for the fix!

@mattyb149 mattyb149 closed this in c3c1b83 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants