-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-12855: Add more information to provenance events to facilitate full graph traversal #8498
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -273,7 +273,7 @@ public interface ProvenanceEventBuilder { | |
ProvenanceEventBuilder setDetails(String details); | ||
|
||
/** | ||
* Sets the to which the FlowFile was routed for | ||
* Sets the relationship to which the FlowFile was routed for | ||
* {@link ProvenanceEventType#ROUTE} events. This is valid only for | ||
* {@link ProvenanceEventType#ROUTE} events and will be ignored for any | ||
* other event types. | ||
|
@@ -283,6 +283,13 @@ public interface ProvenanceEventBuilder { | |
*/ | ||
ProvenanceEventBuilder setRelationship(Relationship relationship); | ||
|
||
/** | ||
* Sets the IDs for the event that happened previously to this event for the given FlowFile | ||
* @param previousEventIds The previous event IDs (usually one except for JOIN events and such) | ||
* @return the builder | ||
*/ | ||
ProvenanceEventBuilder setPreviousEventIds(List<Long> previousEventIds); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this imply we're storing event ids for the before and after event on both the before and after event? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah maybe it is that we had parent FlowFile identifiers and now we'll have previous Event Identfiers. |
||
|
||
/** | ||
* Populates the builder with as much information as it can from the given | ||
* FlowFile | ||
|
@@ -297,7 +304,7 @@ public interface ProvenanceEventBuilder { | |
* {@link ProvenanceEventRecord#getEventId()} on the | ||
* {@link ProvenanceEventRecord} that is returned will yield | ||
* <code>-1</code>. This is because the implementation of the Event may | ||
* depend on the {@link ProvevenanceEventRepository} to generate the unique | ||
* depend on the {@link ProvenanceEventRepository} to generate the unique | ||
* identifier. | ||
* | ||
* @return the event | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.nifi.provenance; | ||
|
||
import java.util.List; | ||
|
||
public interface UpdateableProvenanceEventRecord extends ProvenanceEventRecord { | ||
|
||
void setEventId(final long eventId); | ||
void setPreviousEventIds(List<Long> previousEventIds); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a number of entries here that look like whitespace additions. Please double check and if so remove