Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12960 Added ability to read password-protected Excel spreadsheets. #8658

Closed
wants to merge 2 commits into from

Conversation

dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Apr 16, 2024

Summary

NIFI-12960
In order to test this feature a password protected Excel spreadsheet is created in memory. This is in order to avoid potential issues with virus scanners which will quarantine such a file. In order to test an in memory Excel spreadsheet the underlying API com.github.pjfanning excel-streaming-reader had to be configured not to use temp files (which otherwise would have the same issue of being quarantined by virus scanners).
This PR is specifically for the 2.x branch but I am requesting this be back ported to the 1.x branch if possible otherwise I will open another PR.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @dan-s1, I will review this soon.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this feature improvement @dan-s1! The general implementation looks straightforward. I raised one question on the property naming.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @dan-s1, the latest version looks good. +1 merging and backporting.

exceptionfactory pushed a commit that referenced this pull request Apr 25, 2024
This closes #8658

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit d54e85f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants