NIFI-13078: Adding support to Enable and Disable through the context menu and operation control #8680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcgilman
added
the
new ui
- Adding support to Enable and Disable through the context menu and operation control.
|
reviewing |
rfellows
requested changes
Apr 23, 2024
Comment on lines
+419
to
+422
| startComponentSuccess, | ||
| stopComponentSuccess, | ||
| enableComponentSuccess, | ||
| disableComponentSuccess, |
There was a problem hiding this comment.
We are missing a reducer for enableProcessGroupSuccess and disableProcessGroupSuccess that sets the flowState saving back to false.
If you enable/disable the current process group (right click on the canvas) then try to edit one of the components in that PG, the apply button is a spinner as it thinks it is still "saving"
However, if you were to enable/disable a child pg this isn't an issue as the child pg is reloaded and causes loadChildProcessGroupSuccess to fire which ultimately sets the saving state back to false.
- Addressing review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-13078: