QueryDatabaseTable updates

[patricker]

NIFI-2582 - QueryDatabaseTable should support splitting the ResultSet into multiple flow files
NIFI-2583 - QueryDatabaseTable should allow you to specify an initial Max Value

Appropriate Unit Tests have also been developed.

[mattyb149]

Our coding standards discourage the use of star imports, mind replacing this with the individual imports? Please and thanks!

[patricker]

Yeah, I haven't loaded in the NiFi style guide into IntelliJ; it was just trying to be helpful with the * imports.

Should be all updated.

All of my test cases are very positive outcome focused; not sure if you guys have any goals surrounding negative testing.

[mattyb149]

This guy is still giving checkstyle errors. To run this locally you can use the contrib-check profile when building. I usually do this from the lowest module I'm changing, so nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors:

mvn clean install -Pcontrib-check

[mattyb149]

Your second commit is labelled NIFI-2584, but I believe it's for NIFI-2583. Would you mind re-submitting with the new commit label? Just want to make sure when the merge happens that the Jira trail is correct :) Thanks!

[patricker]

I got CheckStyle working in IntelliJ this morning and all those issues popped right up.
Checkin comment amended.

[mattyb149]

Everything looks good and works well, thanks! @patricker what do you think about adding fragment.count? Could be a later improvement but I think it'd be a good thing to add if not too troublesome

[patricker]

I'll get it in. I didn't add any tests around those attributes, they were more of an after thought, so I'll throw a couple of those in too.

[mattyb149]

Awesome, thanks! Looking forward to these improvements, will make QDT much more flexible and powerful

[patricker]

Improvements are in, along with a few extra steps in the tests to make sure these attributes are checking out.

[mattyb149]

+1 LGTM, thanks again for the great contribution! Merging to master