NIFI-2619: Added logic to ClassLoaderUtils to trim module paths and accept URLs #907
Conversation
|
@mattyb149 will take a look |
| // Split and trim the module path(s) | ||
| List<String> modules = (modulePath == null) | ||
| ? null | ||
| : Arrays.stream(modulePath.split(",")).map((path) -> path == null ? null : path.trim()).filter((item) -> item != null).collect(Collectors.toList()); |
There was a problem hiding this comment.
Executed tests and realized doesn't quite cover for mistakenly added leading commas or leading/trailing commas with blanks before or after them (respectively) e.g. "/src/folder/one.jar1, /src/folder/two.jar, " . Edge case but I think changing the lambda around to blank values in array are filtered out should prevent error:
//Maybe something like this using StringUtils.isNotBlank ?
Arrays.stream(modulePath.split(",")).filter((item) -> StringUtils.isNotBlank(item)).map((path) -> path.trim()).collect(Collectors.toList());
There was a problem hiding this comment.
Good point. I changed to use yours (replacing some things with method references) and added a unit test around the errors you found.
|
@mattyb149 thanks for applying that change. I tested on standalone node with Jolt Transform processor using a list of customjars (included extra commas, spaces etc) and works as expected with no exceptions thrown. +1 Will squash and merge shortly |
No description provided.