NIFI-2641: Add max values as attributes to QueryDatabaseTable #928
Conversation
|
Ran contrib-check on nifi-standard bundle, ran full build with tests. Set up QueryDatabaseTable pointed at Postgres instance, tried numeric and string values for max value. Seems to work as expected, adding maxvalue.column to the FlowFile. +1 |
| @@ -258,6 +260,11 @@ public void onTrigger(final ProcessContext context, final ProcessSessionFactory | |||
| fileToProcess = session.putAttribute(fileToProcess, "fragment.index", String.valueOf(fragmentIndex)); | |||
| } | |||
|
|
|||
| // Add maximum values as attributes | |||
| for (Map.Entry<String, String> entry : statePropertyMap.entrySet()) { | |||
| fileToProcess = session.putAttribute(fileToProcess, "maxvalue." + entry.getKey(), entry.getValue()); | |||
There was a problem hiding this comment.
Hey Matt,
I had been thinking of implementing this same feature, and I have a concern with how it works. I added a property to control the maximum number of rows per FlowFile MAX_ROWS_PER_FLOW_FILE. If this is enabled and multiple files are returned then the maxvalue reported on each FlowFile will be different.
I think that is fine, since it would be the max value in that file, except it might not be... this is because getQuery does not sort by the Max Value Columns, so there is no guaranteed order to the rows. Meaning the value associated might not be max at all, just the max seen so far across all files.
No description provided.