Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUTCH-2786] add a warning for insecure TrustManager #524

Closed
wants to merge 1 commit into from

Conversation

GraceXiaoYa
Copy link

Thanks for your contribution to Apache Nutch! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Nutch issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (NUTCH-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages
  • commits are squashed into a single one (or few commits for larger changes)
  • Java source code follows Nutch Eclipse Code Formatting rules
  • Nutch is successfully built and unit tests pass by running ant clean runtime test
  • there should be no conflicts when merging the pull request branch into the recent master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Nutch in general, please sign up for the Nutch mailing list. Thanks!

@lewismc
Copy link
Member

lewismc commented Dec 17, 2020

@AthenaXiao thanks for the patch. I think it would be more appropriate to provide Javadoc. Can you consider this and resubmit your patch?

@lewismc
Copy link
Member

lewismc commented Jan 8, 2021

@AthenaXiao I'm going to close this issue off. The Class is present in quite a few places within the Nutch source. It is named appropriately and really down to the consumer how they use it. Some Javadoc would be preferred. In the absence of that, this patch is not going to be merged in its current state. Thank you

@lewismc lewismc closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants