NUTCH-2419 Some URL filters and normalizers do not respect command-line override for rule file #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sebastian-nagel
commented
May 12, 2020
sebastian-nagel
commented
- fix urlfilter-domain, urlfilter-domainblacklist, urlfilter-prefix and urlfilter-suffix
- always prefer the configured rule file (urlfilter.domain.file, urlfilter.domainblacklist.file, urlfilter.prefix.file, urlfilter.suffix.file) over the file defined in plugin.xml
- remove constructors taking rule file as argument (used only in unit tests and now obsolete because we can override the rule file via configuration)
- update Java API doc comments
…ne override for rule file - fix urlfilter-domain, urlfilter-domainblacklist, urlfilter-prefix and urlfilter-suffix - always prefer the configured rule file (urlfilter.domain.file, urlfilter.domainblacklist.file, urlfilter.prefix.file, urlfilter.suffix.file) over the file defined in plugin.xml - remove constructors taking rule file as argument (used only in unit tests and now obsolete because we can override the rule file via configuration) - update Java API doc comments
…ne override for rule file - simplify selection of rule file (from property or attribute in plugin.xml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.