NUTCH-3036 Upgrade org.seleniumhq.selenium:selenium-java dependency i… #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR ready or review. Tested on
|
|
Further guidance on browser compatibility/supported platforms Along the way I discovered that full screenshots ar now handled differently so we need to rethink how to do this. For example, the FirefoxDriver has a pretty elegant way of doing this but it is different on other browsers. |
|
There are some tangential proposed changes (such as improvements to logging) to this PR but they concern the relevant Class files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for https://issues.apache.org/jira/browse/NUTCH-3036. Testing ongoing. I’ll also check for additional deprecation notices in the build log.
I’m testing this on MacBook Pro Apple M1 Pro Sonora 14.4.