-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/hx711: add new program to test hx711 chip #2317
Conversation
@mlyszczek please fix the follow warning:
|
These are strings. Aren't strings exempted from this check? I wanted to remove indentation at first, but then checker complains about no indentation. |
you can split to two short string, for example:
|
I think it looks kinda bad, it's harder to see how output is going to be printed and is hard to grep later on. Even Linux allows for long strings without breaking. How about I write patch to nxstyle to ignore such cases? I think it would be enough to simply check if line ends with an |
@mlyszczek I think it is happening on Linux because they increased the column from 80 to 120. If you download an old kernel (i.e. 2.6 series) you will see they enforce 80 column limit event for strings. |
I am all game for 80ch line width. Shorter lines are way But I am against sticking to some arbitrary rule 100% of time. I'm not gonna argue here really, just showing my point of view. And as a bonus some Linux Kernel documentation where 80 still
|
+1 for 80 characters limit |
cb5bbfb
to
0d3de5e
Compare
Very well then. Should be fixed now. It's definitely harder to read, if you ask me. |
Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>
0d3de5e
to
f151de2
Compare
new example program to text hx711 chip