apps/nshlib: Never disable HELP and ? #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarashchenko
approved these changes
Apr 2, 2024
jerpelea
approved these changes
Apr 3, 2024
|
@xiaoxiang781216 could you please merge? |
but defconfig from stm32f103-minimum/nsh need update too. |
|
@acassis please rebase your patch to pass ci. |
|
Done |
It is same as 0 and "Oh", I used the name of CONFIG_NSH_DISABLE_HELP as reference. It is not disabling HELP, but internally it could be disabled if others requirements are not met |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Never disable HELP and ?
Impact
Users will be able to see available commands in NSH
Testing
stm32f103-minimum
Please ignore the CI failing, it needs apache/nuttx#12038 because default board config changed (chichen-egg dilemma).