Skip to content

Commit

Permalink
net/nat: Remove unnecessary logic in inbound logic
Browse files Browse the repository at this point in the history
Finish #12116 (comment)

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
  • Loading branch information
wengzhe authored and jerpelea committed Apr 12, 2024
1 parent 17584ea commit 932c41d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
9 changes: 1 addition & 8 deletions net/nat/ipv4_nat.c
Original file line number Diff line number Diff line change
Expand Up @@ -744,14 +744,7 @@ void ipv4_nat_inbound(FAR struct net_driver_s *dev,
if (IFF_IS_NAT(dev->d_flags) &&
net_ipv4addr_hdrcmp(ipv4->destipaddr, &dev->d_ipaddr))
{
FAR ipv4_nat_entry_t *entry =
ipv4_nat_inbound_internal(ipv4, NAT_MANIP_DST);
if (!entry)
{
/* Inbound without entry is OK (e.g. towards NuttX itself), skip. */

return;
}
ipv4_nat_inbound_internal(ipv4, NAT_MANIP_DST);
}
}

Expand Down
9 changes: 1 addition & 8 deletions net/nat/ipv6_nat.c
Original file line number Diff line number Diff line change
Expand Up @@ -634,14 +634,7 @@ void ipv6_nat_inbound(FAR struct net_driver_s *dev,
if (IFF_IS_NAT(dev->d_flags) &&
NETDEV_IS_MY_V6ADDR(dev, ipv6->destipaddr))
{
FAR ipv6_nat_entry_t *entry =
ipv6_nat_inbound_internal(ipv6, NAT_MANIP_DST);
if (!entry)
{
/* Inbound without entry is OK (e.g. towards NuttX itself), skip. */

return;
}
ipv6_nat_inbound_internal(ipv6, NAT_MANIP_DST);
}
}

Expand Down

0 comments on commit 932c41d

Please sign in to comment.