New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Board port to Arduino Nano 33 BLE #10092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash related commits. Adding board support should be one commit.
If you are using USBD, be aware that it is not yet stable. There is definitely a bug in its implementation that causes usbmsc not to work properly. Probably STALL isn't handled correctly, but I haven't had a chance to fix it yet (USB debugging is not fun at all)
OK I have squashed commits. I have also addressed some of your comments and I have one question. |
Please reformat your PR and make one commit for board support, and separate commits for USB fix and I2C fix. |
@brian-doherty nice board to have on NuttX! As this board has IMU I think it is a perfect board to run Filipe's demo: https://github.com/fdcavalcanti/nuttx-imu-fusion-demo/tree/main |
OK I have fixed everything asked for, tested, and squashed to one commit. The NRF52 fixes are in separate PRs but also still in here since I needed them to test, so you can resolve those PRs first and then everything will be in the right place. |
Ok those PRs have been merged. |
please rebase with the current master and we can merge this PR as well. |
0edb6f1
to
870e81b
Compare
@brian-doherty please remove all change not in arch/arm/src/nrf52/ and boards/ |
Done. My apologies. |
Summary
Board port to Arduino Nano 33 BLE. LEDs, UART, USB, I2C, IMU are all working.
Impact
Now NuttX runs on a new board. :D
Testing
Checked LEDs by hand. Checked USB and UART by running NSH. IMU devices are there.