Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board port to Arduino Nano 33 BLE #10092

Merged
merged 1 commit into from Aug 14, 2023
Merged

Conversation

brian-doherty
Copy link
Contributor

Summary

Board port to Arduino Nano 33 BLE. LEDs, UART, USB, I2C, IMU are all working.

Impact

Now NuttX runs on a new board. :D

Testing

Checked LEDs by hand. Checked USB and UART by running NSH. IMU devices are there.

Copy link
Contributor

@raiden00pl raiden00pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash related commits. Adding board support should be one commit.

If you are using USBD, be aware that it is not yet stable. There is definitely a bug in its implementation that causes usbmsc not to work properly. Probably STALL isn't handled correctly, but I haven't had a chance to fix it yet (USB debugging is not fun at all)

arch/arm/src/nrf52/nrf52_i2c.c Outdated Show resolved Hide resolved
arch/arm/src/nrf52/hardware/nrf52_twi.h Outdated Show resolved Hide resolved
@brian-doherty
Copy link
Contributor Author

OK I have squashed commits. I have also addressed some of your comments and I have one question.

@raiden00pl
Copy link
Contributor

Please reformat your PR and make one commit for board support, and separate commits for USB fix and I2C fix.

@acassis
Copy link
Contributor

acassis commented Aug 8, 2023

@brian-doherty nice board to have on NuttX! As this board has IMU I think it is a perfect board to run Filipe's demo: https://github.com/fdcavalcanti/nuttx-imu-fusion-demo/tree/main

@brian-doherty
Copy link
Contributor Author

OK I have fixed everything asked for, tested, and squashed to one commit. The NRF52 fixes are in separate PRs but also still in here since I needed them to test, so you can resolve those PRs first and then everything will be in the right place.

@brian-doherty
Copy link
Contributor Author

Ok those PRs have been merged.

@raiden00pl
Copy link
Contributor

please rebase with the current master and we can merge this PR as well.

arch/Kconfig Outdated Show resolved Hide resolved
arch/arm/src/nrf52/hardware/nrf52_twi.h Outdated Show resolved Hide resolved
arch/arm/src/nrf52/hardware/nrf52_twi.h Outdated Show resolved Hide resolved
@xiaoxiang781216
Copy link
Contributor

@brian-doherty please remove all change not in arch/arm/src/nrf52/ and boards/

@brian-doherty
Copy link
Contributor Author

Done. My apologies.

@xiaoxiang781216 xiaoxiang781216 merged commit f444de0 into apache:master Aug 14, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to Board in Release Notes - 12.3.0 Sep 27, 2023
@jerpelea jerpelea moved this from Board to done in Release Notes - 12.3.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants