net/icmpv6: Fix value of SIZEOF_ICMPV6_ECHO_xxx_S
#10140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SIZEOF_ICMPV6_ECHO_REQUEST_S` and `SIZEOF_ICMPV6_ECHO_REPLY_S` macro are intended to be `8+n`, but actually becomes `10-1+n` and causes the packet sent by `ping6` one byte more than expected. Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
anchao
approved these changes
Aug 10, 2023
jerpelea
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
SIZEOF_ICMPV6_ECHO_REQUEST_SandSIZEOF_ICMPV6_ECHO_REPLY_Smacro are intended to be8+n, but actually becomes10-1+nand causes the packet sent byping6one byte more than expected.Impact
ping6commandTesting
ping6on sim with wireshark