drivers/input:Fix setting the number of keyboard driver buffers fails #10163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer nums is not multiplied by the structure size Signed-off-by: liuhongchao <liuhongchao@xiaomi.com>
anchao
reviewed
Aug 11, 2023
| @@ -123,7 +123,8 @@ static int keyboard_open(FAR struct file *filep) | |||
|
|
|||
| /* Initializes the buffer for each open file */ | |||
|
|
|||
| ret = circbuf_init(&opriv->circ, NULL, upper->nums); | |||
| ret = circbuf_init(&opriv->circ, NULL, | |||
| upper->nums * sizeof(struct keyboard_event_s)); | |||
There was a problem hiding this comment.
circbuf still needs to be released in failure case
There was a problem hiding this comment.
@HongChao6 please create a new patch fix the leak at line 142.
xiaoxiang781216
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer nums is not multiplied by the structure size
Summary
Impact
Testing