New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver/video: Add Nuttx Goldfish-FB driver #10171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
reviewed
Aug 11, 2023
jianglianfang
force-pushed
the
feat_goldfish_fb
branch
from
August 11, 2023 07:54
2ad6174
to
381d520
Compare
jianglianfang
force-pushed
the
feat_goldfish_fb
branch
3 times, most recently
from
August 11, 2023 12:03
b0cebdc
to
1f008ce
Compare
anchao
reviewed
Aug 11, 2023
acassis
reviewed
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianglianfang please include in the commit log a reference to Android document about the Goldfish: https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT it will make it easier to people discover that it is
xiaoxiang781216
force-pushed
the
feat_goldfish_fb
branch
from
August 12, 2023 15:38
1f008ce
to
1ad93ca
Compare
the register definition is described here: https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT Goldfish-FB driver is to communicate with Goldfish-FB in QEMU, and push the framebuffer data to the emulator for display on the screen. test: CONFIG_GOLDFISH_FB =1, and run demo=>lvgldemo widgets Signed-off-by: jianglianfang <jianglianfang@xiaomi.com>
xiaoxiang781216
force-pushed
the
feat_goldfish_fb
branch
from
August 12, 2023 15:39
1ad93ca
to
a548876
Compare
Done. |
anchao
approved these changes
Aug 13, 2023
acassis
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nuttx Goldfish-FB driver is to communicate with Goldfish-FB in QEMU, and push the framebuffer data to the emulator for display on the screen.
Impact
Add Nuttx Goldfish-FB driver.
Testing