sched/semaphore: Remove restriction to use nxsem_trywait from ISR

[tmedicci]

Summary

• sched/semaphore: Remove restriction to use nxsem_trywait from ISR

It could be called from the interrupt handler because nxsem_trywait is non-blocking, although not recommended.

Impact

Enable applications to call this interface (with CONFIG_DEBUG_ASSERTIONS enabled) without problems. No impact for current implementations.

Testing

Internal CI testing + NuttX CI.

[pkarashchenko]

Seems to be reasonable

[xiaoxiang781216]

need remove the idle check too, since interrupt may also happen in the idle thread.

[pkarashchenko]

Can we add a check to assert if not interrupt context and idle thread than?

[pkarashchenko]

@xiaoxiang781216 do you any ideas about this failure?

2023-08-11T23:32:28.1448456Z make: *** [tools/Unix.mk:680: olddefconfig] Error 1

[xiaoxiang781216]

Can we add a check to assert if not interrupt context and idle thread then?

no, it's legal to call sem_post from the normal thread context.

[pkarashchenko]

This is not about sem_post, but about trywait. I mean to prohibit trywait from the idle task

[xiaoxiang781216]

This is not about sem_post, but about trywait. I mean to prohibit trywait from the idle task

Sorry, it's my typo error. After more think, you can do the assert as your suggestion:

Can we add a check to assert if not interrupt context and idle thread than?

[PetervdPerk-NXP]

This would fix #5142 as well

[tmedicci]

Can we add a check to assert if not interrupt context and idle thread than?

Done! Could you please take a look if it makes sense?