risc-v/mpfs: mpfs_usb: fix tx fifo size setup #10341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently TX_FIFO_SIZE is not altered in mpfs_ep_set_fifo_size(), but all paths (RX and TX) change MPFS_USB_RX_FIFO_SIZE only. Fix the TX_FIFO_SIZE setup. Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
xiaoxiang781216
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently TX_FIFO_SIZE is not altered in mpfs_ep_set_fifo_size(), but all paths (RX and TX) change MPFS_USB_RX_FIFO_SIZE only. Fix the TX_FIFO_SIZE setup.
Summary
The system would like to change MPFS_USB_RX_FIFO_SIZE and MPFS_USB_TX_FIFO_SIZE, but unfortunately in both cases end up modifying the MPFS_USB_RX_FIFO_SIZE only.
Impact
MPFS USB, no notifiable differences
Testing
Flashing images with the patch.