drivers/audio/cxd56: Move cxd56 sources into arch/cxd56xx #10400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CXD56 audio functions are inside of the CXD56. So implementation of it should be under arch directory.
jerpelea
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/cxd56xx/cxd56_nxaudio.c:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/cxd56xx/cxd56_nxaudio_src.c:2:1: error: Relative file path does not match actual file
Fix file path described in top comment for each files.
xiaoxiang781216
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CXD56 audio functions are inside of the CXD56.
So implementation of it should be under arch directory.
Impact
Audio functions on Spresense
Testing
Test if nxaudio works fine.