Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs/libc: Breakdown LIBC_BUILD_STRING into specific string operation… #10408

Merged
merged 1 commit into from Aug 29, 2023
Merged

libs/libc: Breakdown LIBC_BUILD_STRING into specific string operation… #10408

merged 1 commit into from Aug 29, 2023

Conversation

yddhotnet
Copy link

@yddhotnet yddhotnet commented Aug 25, 2023 •
edited by xiaoxiang781216

Summary

Provide a way to only customize specific string operations, such as for memcpy with the DMA capability by ROM.

Impact

Testing

@mu578
Copy link

mu578 commented Aug 26, 2023 •
edited

If you do so, i.e per string functions, they might be more, you never know, it should be propagated to every existing target then. Or then should be something inside memcpy with another bypass flag, make a choice here: either it is a new way, a generalization either specific to only few on demand. Personal opinion: looks like bad juju in that shape.

xiaoxiang781216
xiaoxiang781216 reviewed Aug 26, 2023
View reviewed changes
libs/libc/string/lib_vikmemcpy.c Outdated Show resolved Hide resolved
libs/libc/machine/Kconfig Show resolved Hide resolved
libs/libc/machine/Kconfig Outdated Show resolved Hide resolved
libs/libc/machine/Kconfig Show resolved Hide resolved
libs/libc/libc.h Show resolved Hide resolved
@xiaoxiang781216
Copy link
Contributor

If you do so, i.e per string functions, they might be more, you never know, it should be propagated to every existing target then. Or then should be something inside memcpy with another bypass flag, make a choice here: either it is a new way, a generalization either specific to only few on demand. Personal opinion: looks like bad juju in that shape.

this can be fixed by let LIBC_PREVENT_STRING_[USER|KERNEL] select LIBC_PREVENT_XXX_[USER|KERNEL].

@xiaoxiang781216
Copy link
Contributor

@tmedicci could you review this patch?

@yddhotnet yddhotnet force-pushed the breakdown_LIBC_BUILD_STRING branch 2 times, most recently from 76dc43e to 8198a5d Compare August 29, 2023 04:21
libs/libc: Breakdown LIBC_BUILD_STRING into specific string operation…
e5a1f3d 
…s macro.

Provide a way to only customize specific string operations,
such as for memcpy with the DMA capability by ROM.

Signed-off-by: yangdongdong <yangdongdong@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 1956385 into apache:master Aug 29, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to core in Release Notes - 12.3.0 Sep 27, 2023
@jerpelea jerpelea moved this from core to done in Release Notes - 12.3.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@tmedicci tmedicci Awaiting requested review from tmedicci

@pkarashchenko pkarashchenko Awaiting requested review from pkarashchenko

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 12.3.0
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yddhotnet @mu578 @xiaoxiang781216