Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mm/alloc: remove all unnecessary cast for alloc #10420

Merged
merged 1 commit into from Aug 30, 2023
Merged

mm/alloc: remove all unnecessary cast for alloc #10420

merged 1 commit into from Aug 30, 2023

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Aug 28, 2023 •
edited

Summary

mm/alloc: remove all unnecessary cast for alloc

Fix the minor style issue and remove unnecessary cast

Signed-off-by: chao an anchao@xiaomi.com

Impact

N/A

Testing

ci-check

jerpelea
jerpelea approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a commit message

@anchao
Copy link
Contributor Author

anchao commented Aug 28, 2023

please add a commit message

Done

xiaoxiang781216
xiaoxiang781216 reviewed Aug 28, 2023
View reviewed changes
arch/arm/src/kinetis/kinetis_usbhshost.c Outdated Show resolved Hide resolved
arch/arm/src/kinetis/kinetis_usbhshost.c Outdated Show resolved Hide resolved
arch/arm/src/imxrt/imxrt_ehci.c Outdated Show resolved Hide resolved
arch/arm/src/imxrt/imxrt_ehci.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_usbdev.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_usbdev.c Outdated Show resolved Hide resolved
pkarashchenko
pkarashchenko reviewed Aug 29, 2023
View reviewed changes
arch/arm/src/cxd56xx/cxd56_geofence.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_hostif.c Outdated Show resolved Hide resolved
arch/risc-v/src/bl602/bl602_oneshot_lowerhalf.c Outdated Show resolved Hide resolved
arch/risc-v/src/common/riscv_addrenv_kstack.c Outdated Show resolved Hide resolved
arch/risc-v/src/esp32c3/esp32c3_oneshot_lowerhalf.c Outdated Show resolved Hide resolved
drivers/video/video.c Outdated Show resolved Hide resolved
sched/mqueue/msginternal.c Outdated Show resolved Hide resolved
sched/signal/sig_initialize.c Outdated Show resolved Hide resolved
sched/signal/sig_dispatch.c Outdated Show resolved Hide resolved
sched/signal/sig_allocpendingsigaction.c Outdated Show resolved Hide resolved
@anchao
Copy link
Contributor Author

anchao commented Aug 29, 2023

@pkarashchenko all addressed, thank you!

pkarashchenko
pkarashchenko reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the leftovers and we can move to merge

arch/arm64/src/common/arm64_fpu.c Outdated Show resolved Hide resolved
arch/z80/src/z8/z8_i2c.c Outdated Show resolved Hide resolved
audio/audio.c Outdated Show resolved Hide resolved
drivers/sensors/vl53l1x.c Outdated Show resolved Hide resolved
fs/mount/fs_automount.c Outdated Show resolved Hide resolved
@anchao
Copy link
Contributor Author

anchao commented Aug 29, 2023

Please fix the leftovers and we can move to merge

@pkarashchenko Done, please review again.

xiaoxiang781216
xiaoxiang781216 reviewed Aug 29, 2023
View reviewed changes
Documentation/contributing/coding_style.rst Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_gnss.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_textheap.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_usbdev.c Outdated Show resolved Hide resolved
arch/arm/src/imxrt/imxrt_ehci.c Show resolved Hide resolved
arch/xtensa/src/common/xtensa_oneshot.c Outdated Show resolved Hide resolved
arch/xtensa/src/esp32/esp32_himem_chardev.c Show resolved Hide resolved
boards/arm/stm32/mikroe-stm32f4/src/stm32_appinit.c Show resolved Hide resolved
boards/arm/stm32/stm32f429i-disco/src/stm32_bringup.c Show resolved Hide resolved
drivers/leds/pca9635pw.c Show resolved Hide resolved
@anchao
mm/alloc: remove all unnecessary cast for alloc
e064a83 
Fix the minor style issue and remove unnecessary cast

Signed-off-by: chao an <anchao@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 664927c into apache:master Aug 30, 2023
26 checks passed
@jerpelea jerpelea added this to To-Add in Release Notes - 12.3.0 Sep 26, 2023
@jerpelea jerpelea moved this from To-Add to core in Release Notes - 12.3.0 Sep 27, 2023
@jerpelea jerpelea moved this from core to done in Release Notes - 12.3.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acassis acassis acassis approved these changes

@jerpelea jerpelea jerpelea approved these changes

@pkarashchenko pkarashchenko pkarashchenko approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 12.3.0
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anchao @acassis @jerpelea @pkarashchenko @xiaoxiang781216